esmero / ami

Archipelago Multi Importer. A module of mass ingest made for the masses
GNU Affero General Public License v3.0
2 stars 4 forks source link

Update amiSetEntityForm.php for AMI Update Operations changes #204

Closed alliomeria closed 2 months ago

alliomeria commented 2 months ago

AMI Update Operations changes:

*will need to update the corresponding linked documentation to reflect these changes (will do it this morning in my local docs fork, be ready for pull later today/tomorrow @DiegoPino 🤓 )

alliomeria commented 2 months ago

For these changes @DiegoPino , I was working from the latest local deployment version I have (1.3.0++ at Drupal 10 state). Please let me know if I need to refer to a different version/state or AMI branch. Thank you!

DiegoPino commented 2 months ago

@alliomeria I think you pushed the wrong file for the changes. This should target the amiSetEntityProcessForm and the current commit is targeting the Entity Form itself. See the diff here https://github.com/esmero/ami/pull/204/files, looks odd.

alliomeria commented 2 months ago

Got it @DiegoPino , did indeed copy the changes I had made in my local into the amiSetEntityForm instead of the amiSetEntityProcessForm --corrected now! 😸

alliomeria commented 2 months ago

Ok, I think this resolves the branch version differences @DiegoPino. Let me know what you think. Thank you!

DiegoPino commented 2 months ago

WOHO!!! Well done @alliomeria :)

alliomeria commented 2 months ago

Thanks for reviewing and merging @DiegoPino !