search

esmero / archipelago-deployment

Archipelago Commons Docker Deployment Repository
33 stars 15 forks source link

1.0.0 IIIF V3 CWS Annotations not showing in mirador. #209

Closed DiegoPino closed 1 year ago

DiegoPino commented 1 year ago

This is tested on a local (not showing)

 "annotations": [
                {
                    "id": "http://localhost:8001/do/22cea396-b4ec-11eb-8b96-9fa490fdda0b/iiif/comments/p1",
                    "type": "AnnotationPage",
                    "items": [
                        {
                            "id": "http://localhost:8001/do/22cea396-b4ec-11eb-8b96-9fa490fdda0b/iiif/comments/p1/#4a3a6d50-326c-4b21-98b9-a792912a5a67",
                            "motivation": "tagging",
                            "body": [
                                {
                                    "type": "TextualBody",
                                    "value": "birbi\n",
                                    "created": "2022-08-21T23:01:41.726Z",
                                    "creator": {
                                        "id": "/user/1",
                                        "name": "admin"
                                    },
                                    "purpose": "commenting",
                                    "modified": "2022-08-21T23:01:42.716Z",
                                    "language": "en",
                                    "format": "text/plain"
                                }
                            ],
                            "type": "Annotation",
                            "target": {
                                "source": "http://localhost:8001/do/22cea396-b4ec-11eb-8b96-9fa490fdda0b/iiif/canvas/p1",
                                "selector": {
                                    "type": "SvgSelector",
                                    "value": "<svg xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\"><g><path d=\"M835.5999755859375,146.39999389648438L697.2999877929688,202.89999389648438L629,277L547,370.70001220703125L502.20001220703125,353.1000061035156L368.79998779296875,492.5L311,692.5999755859375L332.3999938964844,743.2999877929688L309,864.2999877929688L394.8999938964844,1056.0999755859375L537.5,1242.199951171875L672.2999877929688,1441.9000244140625L941.0999755859375,1463.5999755859375L1084.199951171875,1606.699951171875L1088.5,1437.5999755859375L1170.9000244140625,1350.9000244140625L1105.9000244140625,1214.0999755859375L1062.5,965L980.0999755859375,698.2000122070312L915.0999755859375,784.9000244140625L689.7000122070312,652.9000244140625L659.2999877929688,557.5L832.7000122070312,479.5L1084.199951171875,228L737.4000244140625,384.1000061035156L997.5,115.30000305175781\"L/></svg> z\"/></g></svg>"
                                },
                                "type": "SpecificResource"
                            }
                        }
                    ]
                }
            ]

This is tested on Studio, showing.

 "annotations": [
  {
                            "id": "https://studio.archipelago.nyc/do/22cea396-b4ec-11eb-8b96-9fa490fdda0b/iiif/comments/p1/#9ca51b96-7716-4ab3-b855-7248c05b43a1",
                            "motivation": "tagging",
                            "body": [
                                {
                                    "type": "TextualBody",
                                    "value": "A Lovely Yellow and Black Watercolored Tucan ",
                                    "created": "2022-03-09T21:37:36.762Z",
                                    "creator": {
                                        "id": "/user/1",
                                        "name": "admin"
                                    },
                                    "purpose": "commenting",
                                    "modified": "2022-03-09T21:37:57.491Z",
                                    "language": "en",
                                    "format": "text/plain"
                                }
                            ],
                            "type": "Annotation",
                            "target": {
                                "source": "https://studio.archipelago.nyc/do/22cea396-b4ec-11eb-8b96-9fa490fdda0b/iiif/canvas/p1",
                                "selector": {
                                    "type": "SvgSelector",
                                    "value": "<svg xmlns=\"http://www.w3.org/2000/svg\" xmlns:xlink=\"http://www.w3.org/1999/xlink\"><g><path d=\"M552.0028076171875,363.17840576171875L501.43603515625,370.4302062988281L429.1781921386719,424.6235656738281L360.53326416015625,522.171630859375L317.1785583496094,666.6873168945312L328.0172119140625,760.6224975585938L320.79144287109375,894.2994995117188L396.66217041015625,1027.9764404296875L685.6934814453125,1421.78173828125L624.2743530273438,1447.0718994140625L664.0161743164062,1454.2977294921875L718.2095336914062,1447.0718994140625L682.0806274414062,1497.6524658203125L710.9837646484375,1544.6199951171875L721.8224487304688,1508.4910888671875L739.8869018554688,1530.16845703125L797.6931762695312,1429.0074462890625L884.4025268554688,1450.684814453125L819.3704833984375,1512.10400390625L833.8220825195312,1559.071533203125L862.7252197265625,1497.6524658203125L891.6283569335938,1486.813720703125L942.2088012695312,1443.458984375L1021.6924438476562,1450.684814453125L1054.20849609375,1541.007080078125L1090.33740234375,1465.1363525390625L1101.176025390625,1410.9429931640625L1140.9178466796875,1313.3948974609375L989.1763916015625,713.6549072265625L945.8217163085938,706.4291381835938L895.2412109375,807.590087890625L783.2415771484375,677.5260009765625L696.5321655273438,645.0099487304688L671.241943359375,551.0747680664062L743.499755859375,507.7200927734375L953.0474853515625,388.4946594238281L1065.047119140625,262.04345703125L992.789306640625,265.6563415527344L783.2415771484375,370.4302062988281L819.3704833984375,287.33367919921875L960.2732543945312,197.0113983154297L1018.0795288085938,153.6566925048828L862.7252197265625,139.2051239013672L725.435302734375,200.62428283691406L617.048583984375,287.33367919921875 z\"/></g></svg>"
                                },
                                "type": "SpecificResource"
                            }
                        }
]

The problem is with the SVG JSON/modification to use Paths. The one that does not work is closing the Tag incorrectly.

This is the source data

    "type": "SvgSelector",
                        "value": "<svg><polygon points=\"835.5999755859375,146.39999389648438 697.2999877929688,202.89999389648438 629,277 547,370.70001220703125 502.20001220703125,353.1000061035156 368.79998779296875,492.5 311,692.5999755859375 332.3999938964844,743.2999877929688 309,864.2999877929688 394.8999938964844,1056.0999755859375 537.5,1242.199951171875 672.2999877929688,1441.9000244140625 941.0999755859375,1463.5999755859375 1084.199951171875,1606.699951171875 1088.5,1437.5999755859375 1170.9000244140625,1350.9000244140625 1105.9000244140625,1214.0999755859375 1062.5,965 980.0999755859375,698.2000122070312 915.0999755859375,784.9000244140625 689.7000122070312,652.9000244140625 659.2999877929688,557.5 832.7000122070312,479.5 1084.199951171875,228 737.4000244140625,384.1000061035156 997.5,115.30000305175781\" \/><\/svg>"
aksm commented 1 year ago

Resolved via a37e2f9a86ec7fb8fbe4b42aef6ea373d4a98b08.