esmero / archipelago_subtheme

Bare bone Archipelago Bootstrap4 Theme
0 stars 5 forks source link

Missing schema for theme #13

Closed marlo-longley closed 4 years ago

marlo-longley commented 4 years ago

What is the problem?

We had no schema loaded into /config/schema/archipelago_subtheme.schema.yml This was generating errors on install.

How to fix

Add the schema. Don't copy the barrio parent theme's /config/schema/bootstrap_barrio.schema.yml because that is also missing schema. My reference point was a combination of /config/schema/bootstrap_barrio.schema.yml and the added schema from this patch: https://www.drupal.org/files/issues/2019-03-06/improve-theme-settings-3037780-3.patch

Test

If http://localhost:8001/admin/reports/config-inspector/archipelago_subtheme.settings/list does not show any errors, then the schema is correct.

DiegoPino commented 4 years ago

Glad that patch i shared helped you find the problem: I will paste how to fix/debug this type of issues, just in case someone finds this in the future. Its one way, there are many

marlo-longley commented 4 years ago

@DiegoPino yes thank you for sharing that patch. These are good directions and helped me understand the theming system better.

Should apply the patch to our base Barrio theme as well (with composer?)

DiegoPino commented 4 years ago

@marlo-longley not bad idea. Since the patch is for 4.x-dev, not sure if it will apply cleanly on our current barrio version. Idea: 💡 Add the patch (URL) to the composer.json patch: key. Then update (composer require ...) the barrio 4.x-dev version. That should trigger an update on that module and also a patching. Check if patch was applied clean. Check if things still look 'decent'! (as deep as possible). If yes =) Then we can move forward and update composer.json and composer.lock

marlo-longley commented 4 years ago

@DiegoPino there is also a patch for 8.x-4.22 (not dev) https://www.drupal.org/project/bootstrap_barrio/issues/3037780#comment-13355761

DiegoPino commented 4 years ago

Well, even better. Still, check if patch applies 🧼:)

El El jue, 13 de feb. de 2020 a la(s) 17:22, Marlo Longley < notifications@github.com> escribió:

@DiegoPino https://github.com/DiegoPino there is also a patch for 4.x (not dev)

https://www.drupal.org/project/bootstrap_barrio/issues/3037780#comment-13355761

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/esmero/archipelago_subtheme/issues/13?email_source=notifications&email_token=ABU7ZZ6OSB3Z6WNE7VFTM73RCXB3PA5CNFSM4KU3QDEKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELW2WEI#issuecomment-586001169, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABU7ZZ6F74KC3TRAAC6R7P3RCXB3PANCNFSM4KU3QDEA .

-- Diego Pino Navarro Digital Repositories Developer Metropolitan New York Library Council (METRO)

DiegoPino commented 4 years ago

Resolved via https://github.com/esmero/archipelago_subtheme/commit/3f6951a65f56a23b79eb2215da6bc13f4de1dd47 and https://github.com/esmero/archipelago_subtheme/commit/82357f39abcf24d98556bcfff87befbe7bb11622