search

esmero / archipelago_subtheme

Bare bone Archipelago Bootstrap4 Theme
0 stars 5 forks source link

Adding a weight to custom.css #23

Open senyzspalding opened 3 years ago

senyzspalding commented 3 years ago

Was thinking it might be a good idea to add a weight to the custom.css to help override items that might be defined in the boostrap.css

I just made this small edit to archipelago_subtheme.libraries.yml in my instance

css/custom.css: { weight:2000 }

DiegoPino commented 3 years ago

@senyzspalding that is a good idea. I guess we can always add !important if we really need to override bootstrap. Any secondary effects after the change?

senyzspalding commented 3 years ago

So far everything looked fine after I made the change. My main reason to implant the weight was was bootstrap uses the !important flag a lot and with the load order their !important flag was taking priority over my !important flag

DiegoPino commented 3 years ago

@senyzspalding that sounds good. Would you be willing to make pull request against 1.0.0-RC2? That would be great if possible.

senyzspalding commented 3 years ago

@DiegoPino I think we will hold off for a week or two while we finish our test run on RC1

DiegoPino commented 3 years ago

@senyzspalding sounds good. I can also do the commit and test if that helps