esmero / format_strawberryfield

Set of Display formatters, extractors and utils to make Strawberry field data glow
GNU Lesser General Public License v3.0
6 stars 9 forks source link

Custom Metadata Display autocomplete Element is filling up the wrong key value collection #187

Closed DiegoPino closed 2 years ago

DiegoPino commented 2 years ago

What?

This is a big bug. I never saw it triggering because this never happens on Archipelago's that are upgraded from previous RC3 versions and was added BY ME on the last release. We have a UUID filling autocomplete for Metadata Display entities that allows to avoid breaking references when updating or reingesting Metadata Displays when preserving the UUID.

But Autocompletes use a special Key Value collection to keep track of settings and that is used in the permissions mechanism to check if the call is coming from a valid caller. FAIL, with this not being right the autocompletes will die with a 403 (Permission denied)

This is going to be a backwards fix on RC3 with a composer.lock update on archipelago-deployment and archipelago-deployment-live

@patdunlavey @aksm @alliomeria we will have to patch a few archipelagos and a Slack forum announcement with the composer command.

DiegoPino commented 2 years ago

Fixed via https://github.com/esmero/format_strawberryfield/commit/f622b0a27baa4ce081f8d6a7a0363eeb42277a8b