search

esmero / format_strawberryfield

Set of Display formatters, extractors and utils to make Strawberry field data glow
GNU Lesser General Public License v3.0
6 stars 9 forks source link

Adds the ability to change the default base URL for the images of IA BookReader #420

Closed roromedia closed 4 months ago

roromedia commented 4 months ago

This is necessary as because of GDPR as it is not allowed to load data from external sources without consent of the user. Now by making the path configurable the user is able to self-host these images.

@DiegoPino : There is for sure a more standardised way to put the default configuration path. I now added a function which returns this path but I guess it would be better retrieved out of a settings-file or via \Drupal::config()?

DiegoPino commented 4 months ago

@roromedia thanks! could you please remove the two dot files from this pull? I will test in the meantime and give you feedback if some changes are needed (If at all). Thanks!!!

DiegoPino commented 4 months ago

I will also change the base branch to 1.4.0. 1.3.0 is closed by now.

DiegoPino commented 4 months ago

@roromedia thanks for addressing the issues. Because of the spacing changes (which are good) I will have to actually git merge this against my local 1.4.0 to be able to see if there are any hidden issues. So please give me until tomorrow noon (EST) to have this properly tested. Thanks again