esmero / strawberry_runners

A post processing Drupal 8/9 module for Strawberryfield dispatched events

GNU Lesser General Public License v3.0

3 stars 2 forks source link

Fix Web64 NlpClient to deal with HTTP 1/1 or 2/0 if that is a thing #54

Closed DiegoPino closed 2 years ago

DiegoPino commented 2 years ago

What?

Yes, code was hardcoded to deal with only HTTP 1/0 200 OK. Which is like c'mon people! Our newest build of the nlp64 container updated its web server to HTTP 1/1 and now the client is broke.

Solution, extend, override, fix.

DiegoPino commented 2 years ago

Fixed via https://github.com/esmero/strawberry_runners/commit/fc4cd45c3df6a801abf13f359464e28a3dfe6b34 Eventually we will refactor/recreate the whole NLP64 client which is very very basic

digitaldogsbody commented 2 years ago

Fixed via fc4cd45 Eventually we will refactor/recreate the whole NLP64 client which is very very basic

I'm on it!