search

esmero / strawberryfield

A Field of strawberries
GNU Lesser General Public License v3.0
10 stars 5 forks source link

ISSUE-237: Move ADO Tools into this module, make JMESPATH a subsection + add a view for listing children #238

Closed aksm closed 1 year ago

aksm commented 1 year ago

Starts to resolve #237.

Move existing ADO Tools menu and JMESPATH codemirror library and update any references. This just moves everything over from strawberry_runners while retaining the exact same functionality (tested).

esmero/strawberry_runners#63 should be merged before merging this.

DiegoPino commented 1 year ago

@aksm hi. This is bringing commits that don't belong here. Are those OK? e.g src/Controller/StrawberryfieldFlavorDatasourceSearchController.php

Can you please double check/rebase and cleanup? Thanks

aksm commented 1 year ago

@DiegoPino I had merged in recent changes up to that point. Should I merge in the further changes since?

@aksm hi. This is bringing commits that don't belong here. Are those OK? e.g src/Controller/StrawberryfieldFlavorDatasourceSearchController.php

Can you please double check/rebase and cleanup? Thanks

DiegoPino commented 1 year ago

@aksm normally you don't need to merge other changes. You fetch a branch, create a new one from that one and you only modify what you need too. Only reason to merge other changes is when you are touching those files. Here you can rebase to 1.1.0. Or are these changes in 1.0.0 not present in 1.1.0?

aksm commented 1 year ago

Ah ok, these were just recent changes from 1.1.0. I'll roll back and keep just my commit.

aksm commented 1 year ago

@DiegoPino Will make a separate PR for the views needed for this, but here is what I used for developing/testing:

ado_tools_children_views.zip

aksm commented 1 year ago

Hi @DiegoPino, except for the views (see above comment), I think this is ready for review.

DiegoPino commented 1 year ago

@aksm thanks. Will review during the day!

DiegoPino commented 1 year ago

@aksm regarding the default views. I would explore using the config/install folder of this module and see also this function search_api_solr_update_helper_install_configs (as a reference) which should allow us to deploy selectively the new views via an update hook (v/s having to uninstall/reinstall the module)

See also https://www.drupal.org/docs/creating-modules/include-default-configuration-in-your-drupal-module

aksm commented 1 year ago

@DiegoPino I basically copied the function you referenced above as is in order to push the commits in by EOD Friday (which failed anyway because I was in a detached head state and ended up coming back later in the evening here: 00ec5c9a3f0c1a03c27de2d79ce28cb68d5a9224), and it seemed to work when I tested, but I'm glad to keep on it if you think there's more needed or if anything's missing. Either way, I'm sure the views will need more tweaking.

DiegoPino commented 1 year ago

@aksm thanks. I will try ti get back to this early morning Monday. Have a full day of IIIF (even if half Sunday is over) ahead so might better look at this with fresh eyes. Hugs and thanks again