ISSUE-247: Fix bug on parent of parent and cleanup empties for legacy OCR

esmero / strawberryfield

A Field of strawberries

GNU Lesser General Public License v3.0

10 stars 5 forks source link

ISSUE-247: Fix bug on parent of parent and cleanup empties for legacy OCR #248

Closed DiegoPino closed 1 year ago

DiegoPino commented 1 year ago

See #247 and #244

The legacy OCR cleanup is a temp fix for WIP 1.1.0. Soon this will also be commited back into the backend AND will be only a workaround.
The bug is(I am) stupid, instead of assigning the $referencedEntity to a new key i was retrieving a non existing key! December...

DiegoPino commented 1 year ago

@alliomeria this needs to be merged and applied to a bunch of repos. Won't affect anything (the bug) as it is now but will throw a few warnings. The OCR fix allows old OCR (e.g studio) to be indexed correctly into 1.0.0's newer Solr plugin

aksm commented 1 year ago

@DiegoPino This looks good to me!

DiegoPino commented 1 year ago

@aksm thanks!