esmero / strawberryfield

A Field of strawberries
GNU Lesser General Public License v3.0
10 stars 5 forks source link

Hydroponics does not update its enabled queues list while already running #259

Open DiegoPino opened 1 year ago

DiegoPino commented 1 year ago

What?

Once Hydroponics quicks in Queues marked to be processed by it are read once and used. Any attempt to disable a queue (e.g you know you want to stop processing for a while the background one) will have no effect. That is not ideal.

At least on each Hydroponics round robin (means when it swaps context from one queue to the other) we should re-check what queues are enabled to respect configuration changes

@alliomeria I just noticed this today. While it was running I disabled the Background (OCR) one but OCR kept being executed.

It would be also idea to have a "stop/you did enough" state setting that is not killing Hydroponics but allows it to shutdown gracefully after it finishes one item. Would be ideal that also a "time to live" update could trigger a change. If set to live "0" means until finish setting 720 should change the scope and allow Hydroponics to shutdown sooner.

Lastly:

dmer commented 1 year ago

This is excellent! Super useful tools for repo admins trying to manage large scale ingest/migration. We have been negotiating with Hydroponics a lot in the CAR site - upping the system resources has helped, but I have been wishing for more visibility into what it's doing, when as well as a teeny bit more control over gracefully pausing/stopping things to sort out an issue or allow some other big process to happen. Stats would also help in providing folks with better prediction and better diagnostics. Pat's away this week, but I will look at this closely w/ him to see if we can think of any other suggestions for this area. Thanks!