esmero / strawberryfield

A Field of strawberries
GNU Lesser General Public License v3.0
10 stars 5 forks source link

Allow ap:tasks entry to define what JSON key can alternatively (other than label) drive the NODE title #261

Open DiegoPino opened 1 year ago

DiegoPino commented 1 year ago

What?

So far we have fixed that label key will drive always an ADO/NODE title. There are times (specially on multiligual Repositories) when we want to make one exception. ap:tasks is the key for machinable instruction to be given to Archipelago.

This ISSUE will support code that will provide

"ap:tasks": {
        "ap:entitytitle": "JMESPATHEXPRESSION"
    }

I'm keeping a lowercase no _ nomenclature for these keys but happy to revision this @alliomeria @aksm if you think we should use CamelCase or _ for this key.

The code will modify a few lines here https://github.com/esmero/strawberryfield/blob/78f4bdb5ca57e522e85c139c3db99ca6cebdd728/src/EventSubscriber/StrawberryfieldEventPresaveSubscriberSetTitlefromMetadata.php

Thanks

alliomeria commented 1 year ago

Sounds great, thank you @DiegoPino! Lowercase approach makes sense to me too.

DiegoPino commented 1 year ago

Thanks @alliomeria