search

esmero / strawberryfield

A Field of strawberries
GNU Lesser General Public License v3.0
10 stars 5 forks source link

accessCheck needed in \Drupal\strawberryfield\StrawberryfieldFilePersisterService::removeUsageFilesInJson #294

Closed patdunlavey closed 9 months ago

patdunlavey commented 9 months ago

Starting to work on my D10.1 upgrade and I hit the \Drupal::entityQuery accessCheck error here: https://github.com/esmero/strawberryfield/blob/ff229bb45864d6438a053d3921290c27b8192bc0/src/StrawberryfieldFilePersisterService.php#L1083

To fix this, just need to change that line to

            )->accessCheck(FALSE)->execute();

(I'm presuming that since there was no pre-existing accessCheck, that the correct value should be FALSE.)

DiegoPino commented 9 months ago

hu! I thought I had caught all of those? Yes false is Ok. Wonder why none of the repos have complaint about this already. Thanks! Want me to make the pull or you ready for an 1.3.0 pull right now? thanks!!!

patdunlavey commented 9 months ago

If you don't mind doing it, it will be fewer steps. Thanks.

DiegoPino commented 9 months ago

Got it! Thanks for reporting

DiegoPino commented 9 months ago

@patdunlavey can you check/approve both pulls? Thanks again!

DiegoPino commented 9 months ago

Solved. Thanks @patdunlavey