ISSUE-300: Safer trim on JSON values from key name provider

esmero / strawberryfield

A Field of strawberries

GNU Lesser General Public License v3.0

10 stars 5 forks source link

ISSUE-300: Safer trim on JSON values from key name provider #301

Closed DiegoPino closed 6 months ago

DiegoPino commented 7 months ago

See #300

@patdunlavey can you please test/see/look at the code and see if anything is amiss?

And if all works, approve? Thanks!

DiegoPino commented 7 months ago

@patdunlavey thanks. The extra checks on FALSE and 0 are because an array filter will remove actual 0 and booleans from the JSON and there might (they are really) needs of being able to index flags/boolean data into Solr.

I have a test suit for this. Will just ingest a few objects with empty arrays/nulls, etc and if all goes well merge. Thanks

patdunlavey commented 7 months ago

Great! Thank you!!!