esmero / strawberryfield

A Field of strawberries
GNU Lesser General Public License v3.0
10 stars 5 forks source link

Basic IABookreader Search Controller misbehaves when a CWS Child uses it directly #305

Closed DiegoPino closed 5 months ago

DiegoPino commented 6 months ago

What?

Because our most basic Flavor driven Search Controller for OCR is unaware of IIIF Manifests (and we have now the Search API enabled endpoints that are really smart), when a CWS child has a IABookreader attached directly and e.g has a PDF, the Page used to return the results is swapped for the relative to the parent Sequence ID, making all results appear on the same page.

This controller was always meant to deal with the simplest use cases. All media of a normal ADO being displayed (e.g a single PDF) or each CWS child being a single page.

The fix (very specific for this use case) is simple but won't resolve the issue of e.g a CWS IIIF Manifest with complex multi page per CWS child data being displayed at the top level Object, so really a definitive fix requires

Once question I have for you @alliomeria is:

DiegoPino commented 5 months ago

Resolved via https://github.com/esmero/strawberryfield/commit/4a8a450072f108234ad8dfdcf508d0c91e766904