esmero / strawberryfield

A Field of strawberries

GNU Lesser General Public License v3.0

10 stars 5 forks source link

Silly old bug, valid Strawberry Flavor index check is not right #313

Closed DiegoPino closed 5 months ago

DiegoPino commented 5 months ago

What?

When you have multiple indexes you want totally avoid making queries for SBF if that index does not support it. That should be OK if I had tested with multiple indexes from the start. I have a return in the wrong place!

See 😮‍💨 https://github.com/esmero/strawberryfield/blob/4a8a450072f108234ad8dfdcf508d0c91e766904/src/Plugin/search_api/datasource/StrawberryfieldFlavorDatasource.php#L729-L745

DiegoPino commented 5 months ago

See https://github.com/esmero/strawberryfield/pull/309/commits/8adaa803b0fd5679baa93b2785b7ab8cfccb65a2

DiegoPino commented 5 months ago

Resolved via https://github.com/esmero/strawberryfield/commit/5319d100356b0dfc02b93c18646f7bbaa41c9db0