search

esmero / webform_strawberryfield

Provides Webform integrations to feed a field of Strawberries. Mr. Wizard of WebOz
GNU Lesser General Public License v3.0
2 stars 6 forks source link

ISSU-119: Validate/Clean non valid UTF-8 CSV data imports via webform elements #120

Closed DiegoPino closed 3 years ago

DiegoPino commented 3 years ago

See #119

Adds a new Option for the Metadata CSV upload element. If checked, CSVs with invalid UTF-8 characters will be validated/rejected at the Form Element level. If not, we will still do sanity/clean and checks

Finally added some Visual/UI/Logs help in case something weird happens with the data we have no control over during a Webform ingest. Should not happen since this is the only Element Family that injects data directly into the SBF JSON and this is NOW! solved. But maybe someone ends doing data magic in the future too.

DiegoPino commented 3 years ago

@patdunlavey @giancarlobi if any of you could give this a quick visual pass and see if anything here makes noise/looks weird for you, I would be thankful. I tested this and it is working but good to have your wisdom and experience detecting outer space bugs here. Thanks!

patdunlavey commented 3 years ago

Hi @DiegoPino visual looks good to me. I'm impressed with your economy of code, which makes it reasonably easy to to follow what's going on, and to be pretty confident that regressions are not being introduced.

Do you want me to do some testing? If so, perhaps more expansive testing instructions would be helpful.

DiegoPino commented 3 years ago

@patdunlavey thanks a lot (and thanks for your kind words). I will do some extra cleanup (saw a DCS issue) and then follow up with a set of example CSVs. I really appreciate your quick response on this, Gold medal for you 🥇

DiegoPino commented 3 years ago

Merging into RC3. Thanks.