search

esmf-org / esmf-profiler

ESMF Profiler application converts binary traces into a web based, dynamic report.
0 stars 2 forks source link

Add username to site.json #31

Closed ryanlong1004 closed 2 years ago

ryanlong1004 commented 2 years ago

In order for links to work when the site is published to github pages, the web app will need the username passed to it in the JSON.

When the user click an option, that <username>/<name> will have to be prefixed to each call. Otherwise, they're take back to root.

rsdunlapiv commented 2 years ago

This is not a good solution. The site should only use URLs relative to the root of the static site. The reason is that once a static site is generated, the user should be able to deploy it anywhere, and even move it around. So we cannot count on anything in the URL prior to the root where it is deployed.

We need not solve this now anyway, since there is only one link in the side bar, which can simply be linked to "#".

ryanlong1004 commented 2 years ago

Closing per @rsdunlapiv