esmf-org / esmf-test-scripts

Scripts for automated regression testing of ESMF
2 stars 6 forks source link

Update hera.yaml #68

Closed ryanlong1004 closed 2 years ago

ryanlong1004 commented 2 years ago

Explicit cmake.

rsdunlapiv commented 2 years ago

@ryanlong1004 the extramodule for cmake is needed for all compilers. Here you have only added this to intel. Please also add to gfortran and PGI.

theurich commented 2 years ago

It's good to have cmake added to all combos now. However, note that even when it was just added to intel (last night), it did NOT fix the build issue with intel. In fact, we now have a new issue on hera/intel that we did NOT have before: hera/intel/mpiuni built the library fine yesterday, but today it is failing. Folks that make changes, either on the test environment, or the library code itself need to keep an eye on the nightly tests. It should not go unnoticed that today's pio_update2 results look worse than yesterday's. For this branch I think the responsibility is primarily on @ryanlong1004 and @jedwards4b.

jedwards4b commented 2 years ago

Is this todays build? The NetCDF version is still 4.7.2

rsdunlapiv commented 2 years ago

I think I see the issue with the cmake module. It was added here to Hera/intel 18: https://github.com/esmf-org/esmf-test-scripts/commit/c726124fb81e74505666ef2c76363da801009b01

However, it was added too deeply in the YAML below the "18.0.4:" key. Instead, it should be added under the "intel:" key one level up in the YAML.

Note the position of the "extramodule:" in acorn.yaml.

@ryanlong1004 please move these "extramodule: cmake" commands up one level in hera.yaml. Then please confirm when the tests run again that the new module was in fact loaded for each of the compiler combinations.

jedwards4b commented 2 years ago

In this one. The c++ and fortran compilers are intel but the c compiler is gcc and it's trying to set intel based flags - can you change the c compiler to use icc?

jedwards4b commented 2 years ago

Netcdf version 4.7.2

jedwards4b commented 2 years ago

CMAKE version 2

jedwards4b commented 2 years ago

Needs to be changed

ryanlong1004 commented 2 years ago

@rsdunlapiv

https://github.com/esmf-org/esmf-test-scripts/commit/a0b058c6c4a441a42dd495f6c03080d9c7a1b27a