esmf-org / esmf

The Earth System Modeling Framework (ESMF) is a suite of software tools for developing high-performance, multi-component Earth science modeling applications.
https://earthsystemmodeling.org/
Other
153 stars 75 forks source link

Complete time manager & alarm fixes #69

Open rsdunlapiv opened 2 years ago

theurich commented 1 year ago

@rsdunlapiv - It would be good to have a description of the current status of this, and what the outstanding issues are before you leave.

theurich commented 1 year ago

@rsdunlapiv do you remember what branch is associated with this issue? Is it https://github.com/esmf-org/esmf/tree/newalarm? Thanks.

billsacks commented 10 months ago

See also https://docs.google.com/document/d/1ZlI12Q8XPwQgPCuu1feyrUorhfuxkxhQMG50Iv97jU8/edit - sent by Arun Sept 14, 2023 with the note:

One key requirement as we look forward to Data Assimilation is being able to move the model forward and backward which will have some work to be done on the ESMF clock side of things. I am forwarding you a requirements document with the kinds of tests we would like to see the model pass.

anntsay commented 8 months ago

Other related alarm tickets: https://github.com/esmf-org/esmf-support/issues/11, https://github.com/esmf-org/esmf-support/issues/15

anntsay commented 8 months ago

recap meeting.. may need to update the branch to 8.7.

anntsay commented 7 months ago

Dan said that Fei had tried it but we need to test out other places/systems. Action - give UFS team the branch to try out time management. (Ann to follow up in the next UFS meeting).

anntsay commented 6 months ago

That this is NOT backward compatible and therefore need to move the branch to 9.0

billsacks commented 6 months ago

That this is NOT backward compatible and therefore need to move the branch to 9.0

After a bit more discussion, we're not sure about this point. The key question is whether alarms are still sticky by default. Our initial thinking was that alarm stickiness is no longer supported, which would break backwards compatibility, but from further discussion, it seems like we're not sure about that point and it needs some further investigation.

anntsay commented 1 month ago

Action: 1. look at the original issue.

  1. design based

Consideration: has a new alarm class to try it out. but may also need to consider clock.

Impact: NASA is still asking about this.