Ignore : in include guard strings.

esnacc / esnacc-ng

A continuation of the Enhanced SNACC ASN.1 compiler - See http://mail.esnacc.org/mailman/listinfo/dev

http://esnacc.org

GNU General Public License v2.0

32 stars 30 forks source link

Ignore : in include guard strings. #57

Closed schorsch1976 closed 6 months ago

schorsch1976 commented 1 year ago

If you compile a file with an absolute windows path, the : in the path get passed along into the include guard. The : makes the guard define invalid. That patch replaces the : by a _.

apconole commented 1 year ago

This looks good, but we follow DCO on esnacc. Please make your commit message conform to DCO by including a signoff tag.

Additionally, I suggest the subject look like:

compiler: windows back-end: Filter ':' in include guards.

Thanks for the contribution!

schorsch1976 commented 1 year ago

Updated the commit Header and added a signed off. Tried to subscribe to the dev mailing list and send it there but it encountered a bug.

apconole commented 6 months ago

For some reason, when I had hit the merge button it hadn't merged - and I didn't notice. Just saw this was still outstanding. Sorry for the long delay. Merged.