search

esnet / react-timeseries-charts

Declarative and modular timeseries charting components for React
http://software.es.net/react-timeseries-charts
Other
866 stars 284 forks source link

Brush component is not working on mobile devices #206

Open tista3 opened 6 years ago

tista3 commented 6 years ago

You can test this on the cycling example: http://software.es.net/react-timeseries-charts/#/example/cycling?_k=h3dw4u Could it be handled like the amcharts do this? https://www.amcharts.com/kbase/getting-selection-chart-without-zooming/

pjm17971 commented 6 years ago

Seems reasonable. There's quite a few issues on mobile devices unfortunately.

acomito commented 5 years ago

I've been hacking a similar component as brush using a slider (https://github.com/davidchin/react-input-range#readme). That one also has issues on mobile. In particular the onDrag (dragging the whole window/block) is not working on mobile.

Would love to see mobile support (or in our case tablet) for the brush.

I didn't check the ios/safari console for whats up, but I had a little trouble opening this link on my iphone: http://software.es.net/react-timeseries-charts/#/example/cycling?_k=h3dw4u

Thanks for the great library. Love the api.

jagribble commented 4 years ago

@acomito @tista3 unsure if you are still looking at using this. But I have made a PR that allows for the Brush to be used on mobile.

@pjm17971 Do you mind having a look?