search

esnet / react-timeseries-charts

Declarative and modular timeseries charting components for React
http://software.es.net/react-timeseries-charts
Other
861 stars 284 forks source link

minBarHeight and zero'd values don't render #364

Open webchaz opened 5 years ago

webchaz commented 5 years ago

❔Question

Using the BarChart, I haveminBarHeight set to 0 and data points that looks like this:

      ["2015-12-1", 80, 38, 44, 100, "id"],
      ["2015-12-2", 17, 20, 29, 100, "id"],
      ["2015-12-3", 2, 67, 60, 100, "id"],
      ["2015-12-4", 73, 77, 79, 100, "id"],
      ["2015-12-5", 0, 0, 0, 100, "id"],
      ["2015-12-6", 58, 57, 78, 100, "id"],
      ["2015-12-7", 72, 59, 52, 100, "id"],
      ["2015-12-8", 12, 34, 9, 100, "id"],
      ["2015-12-9", 82, 36, 58, 100, "id"]

For 2015-12-5 You'll notice that 3 of the columns are 0 and one is 100. In this case, nothing renders for that day. Should it be expected that the one data point that's 100 would render, whereas the others simply would not?

Thank you!