search

esnet / react-timeseries-charts

Declarative and modular timeseries charting components for React
http://software.es.net/react-timeseries-charts
Other
861 stars 284 forks source link

React StrictMode causes warnings #368

Open davegravy opened 5 years ago

davegravy commented 5 years ago

🐛Bug report

Describe the bug Warnings reported when using React StrictMode

To Reproduce Steps to reproduce the behavior:

  1. Wrap ChartRow, TimeAxis, and YAxis components in <React.StrictMode>
  2. See warnings:

componentWillMount: Please update the following components to use componentDidMount instead: ChartRow

componentWillReceiveProps: Please update the following components to use static getDerivedStateFromProps instead: ChartRow, TimeAxis, YAxis

Expected behavior No warnings

Desktop (please complete the following information):

dirkdevriendt commented 4 years ago

FYI / for reference: similar issue + PR that solves it in the react-vis repository https://github.com/uber/react-vis/pull/1253