esnet / react-timeseries-charts

Declarative and modular timeseries charting components for React
http://software.es.net/react-timeseries-charts
Other
861 stars 284 forks source link

fix: intermittently click not work on EventChart on Google Chrome, totally not working on Safari #369

Closed phonglk closed 5 years ago

phonglk commented 5 years ago

While working on EventChart, we observed that the click event on EventChart is not working 100% of the time. So I open it here just in case if anyone faces the same issue. The issue is very hard to reproduce on Google Chrome but it always happen on Safari. Through investigation, we notice the following points

This change just makes sure that the grey <rect /> are not accepting pointer events (hence the EventChart's <rect /> would receive it) since it just to visualize the dragging area, it should not affect anything.