search

esnet / react-timeseries-charts

Declarative and modular timeseries charting components for React
http://software.es.net/react-timeseries-charts
Other
861 stars 284 forks source link

Fix YAxis rerender on tickCount/min/max change #372

Closed kradical closed 5 years ago

kradical commented 5 years ago

Hello again! Here is my fix for the issue I reported.

Issue: https://github.com/esnet/react-timeseries-charts/issues/371

I have previously committed to this component with a different fix. Also this is a small bug with a fairly simple solution so hopefully this gets merged quickly! Thanks again for all your hard work on this library!

Also when I ran the build step it looks like some other stuff got built too :man_shrugging: , see my first commit for the actual code changes!

Fixed Screenshots: On first render: screenshot from 2019-02-12 22-37-43 After changing tickCount/min/max: screenshot from 2019-02-12 22-43-56

See Issue for broken screenshots.

Cheers,

Konrad

kradical commented 5 years ago

Hello @sartaj10 I was just wondering on the status of this? Do you think it is possible to get it merged in soon? And maybe do a release sometime in the near future?

Let me know if there is anything I can do to help!

kradical commented 5 years ago

No worries, thanks @pjm17971 ! Do you know when the next release will be, with this fix in it?

sartaj10 commented 5 years ago

@kradical Yes, the next release will have this fix in it. We're waiting for one more PR that has some merge conflicts and if that can be fixed this week, we'll release a new version by the end of this week.