fix: only set passive false on scroll wheel events

esnet / react-timeseries-charts

Declarative and modular timeseries charting components for React

http://software.es.net/react-timeseries-charts

Other

861 stars 284 forks source link

fix: only set passive false on scroll wheel events #380

Closed pjm17971 closed 5 years ago

pjm17971 commented 5 years ago

The previous change (https://github.com/esnet/react-timeseries-charts/pull/376) broke event propagation causing the MultiBrush (traffic) example to stop working correctly. Just putting this fix onto the scroll event seems to fix the page scrolls when zooming a chart issue, along with the chrome error messages.

Note: the only important file for the passive handler change is EventHandler.js (but the CHANGELOG is also updated in this PR for @sartaj10 to check over).

cc: @igozali

igozali commented 5 years ago

LGTM. Only somewhat related but I recently found another issue regarding "mouseup" vs. "pointerup" events in Chrome, but only noticed it when I started experiencing unwanted behavior recently. I'll file another issue for this - wanted to see if you've encountered a similar problem before...