Refresh Typescript version in `updates-typescript`

igozali commented 5 years ago

So I took some time to refresh the Typescript version (3.4.5) on the long-awaited updates-typescript branch in the hopes that it would have better compatibility with storybook (kind of a long shot since I have no idea yet how storybook works).

I got it to a point where I can run lerna bootstrap && lerna build and only have errors in website_ts and website (i.e. react-axis and react-timeseries-charts compiles fine). Since I don't quite know which one is being worked on more, I decided to stop here and ask for your comments.

Quick summary:

Update typescript to 3.4.5. There were quite a lot of downstream issues as a result of this update (mostly incompatibilities in typing), but luckily I didn't have to change much of the code to make it work, and most of the changes are in package.json file.
Use react-scripts@3.0.0 since react-scripts-ts is deprecated
Changed a few dependencies in website_ts to make React typings work (previously it was failing with this error)
Did a bit of work for typings in website_ts.

Hope it helps a bit, and would be great if you could try it out. Let me know if you have any comments or questions. :)

igozali commented 5 years ago

In case you don't have notifications enabled.. @pjm17971 @sartaj10

pjm17971 commented 5 years ago

Thanks for this, I'm planning to try it out.

esnet / react-timeseries-charts

Refresh Typescript version in `updates-typescript` #393