search

esnet / react-timeseries-charts

Declarative and modular timeseries charting components for React
http://software.es.net/react-timeseries-charts
Other
861 stars 284 forks source link

pass trackerValues thru to infoValues #402

Closed brandly closed 5 years ago

brandly commented 5 years ago

before this patch, setting trackerValues on ChartContainer appears to do nothing.

i described the issue in a comment. the info prop doesn't exist at all on TimeMarker.

the docs say this about showInfoBox:

    /**
     * Display the info box at all. If you don't have any values to show and just
     * want a line and a time (for example), you can set this to false.
     */
    showInfoBox: PropTypes.bool,

however, with showInfoBox={false}, i wouldn't see anything besides the line -- no time indicator or anything. maybe these docs are incorrect.

setting showInfoBox={!!this.props.trackerValues} allows me to make use of trackerValues.