esnet / react-timeseries-charts

Declarative and modular timeseries charting components for React
http://software.es.net/react-timeseries-charts
Other
861 stars 284 forks source link

Box styling on TimeMarker doesn't work #405

Open pbatleyGH opened 5 years ago

pbatleyGH commented 5 years ago

🐛Bug report

Styling the box using infoStyles = {..., box: ...} does not do anything on a TimeMarker component.

I believe that this is because:

line 73 of TimeMarker.js unpacks the box property style: this.props.infoStyle.box,

then renders a label component which attempts to again unpack the box property style.box

function mergeStyles(style, isCentered) {
    return {
        boxStyle: merge(true, defaultBoxStyle, style.box ? style.box : {}),
        labelStyle: merge(
            true,
            isCentered ? defaultTextStyleCentered : defaultTextStyle,
            style.label ? style.label : {}
        )
    };
}

(to anyone needing a workaround, use: infoStyles = {..., box: { box: {...} }})

brandly commented 5 years ago

i believe this was fixed in #403