search

esnet / react-timeseries-charts

Declarative and modular timeseries charting components for React
http://software.es.net/react-timeseries-charts
Other
859 stars 283 forks source link

Zero data and minBarHeight=0 breaks multiple columns in BarChart #411

Open damonmaria opened 5 years ago

damonmaria commented 5 years ago

🐛Bug report

Describe the bug When multiple columns are supplied for a BarChart, and minBarHeight={0} is used, then the first column that has 0 data will stop later columns rendering.

This happens because this line of code should continue, not break.

To Reproduce

364 has a good example that produces this.

Expected behavior Even when one bar is zero height, the other bars should render still.

Desktop (please complete the following information):

DireLines commented 2 years ago

I have the same issue and the pull request will fix it