esnet / react-timeseries-charts

Declarative and modular timeseries charting components for React
http://software.es.net/react-timeseries-charts
Other
859 stars 283 forks source link

EventMarker Flag Not Visible Outside ClipPath #436

Open eternaldoctorwho opened 4 years ago

eternaldoctorwho commented 4 years ago

When using an EventMarker of type "flag" in combination with a EventChart, the actual flag popup will not appear. This is because it is by default outside of the clipPath generated for the EventChart area. This is especially true if the EventMarker flag is styled to appear above or below the Event data line.

What if we made that clipPath in the ChartRow component optional via a prop? At least for an EventChart, the Event bar would only show with slightly more height, and the flag popup would appear on hover.