esnext / es6-module-transpiler

Tomorrow’s JavaScript module syntax today
http://esnext.github.io/es6-module-transpiler/
Other
1.21k stars 85 forks source link

Add option to not generate source map and append sourceMappingURL #164

Closed AdamFerguson closed 9 years ago

AdamFerguson commented 10 years ago

Firstly, great project, thanks. I'd like to disable source map generation on the application I'm working on b/c 1) for production builds and 2) the sourceMappingURL that is appended doesn't contain the relative path info of the location the individual files that are being compiled so it ends up resulting in the browser making lots of 404 requests for source map files it can't find.

I looked through writer.js, where source maps are being generated, and doesn't look like the option exists. Am I missing it?

caridy commented 10 years ago

/cc @ericf

ericf commented 10 years ago

Agreed. We should make this configurable. We also ran into an issue when combining modules together from different npm packages into a single Bundle format output — two packages using the same file name rendered the source maps useless since it was missing sourceContents for the dup file names.

It seems like an option to configure the sourceMappingURL, plus the source contents file names is needed. And that could go along with an option to disable outputting source maps entirely.

eventualbuddha commented 10 years ago

I've poured more time than I really had into this recently and need to back off for a week or so. I'd be up for reviewing PRs, though!

AdamFerguson commented 10 years ago

I'll try and work on a PR for it this weekend. Thanks again for the project!

eventualbuddha commented 9 years ago

Ping @AdamFerguson.

AdamFerguson commented 9 years ago

@eventualbuddha Pulled it down and started working on it, then got distracted by other things. I'll take another look tonight.

jdalton commented 9 years ago

Any updates?

eventualbuddha commented 9 years ago

I'm going to close this partly due to inactivity, but also because I'm working to make http://esperantojs.org/ the module transpiler of choice.