search

esoergel / coderaising

The main website for CodeRaising.org
2 stars 0 forks source link

Case sensitive tags #19

Closed natea closed 11 years ago

natea commented 11 years ago

The tags seem to be case sensitive, so when I click on "django" I get a different list of users than when I click on "Django". These should probably be normalized so we get a complete set. http://coderaising-ethan.herokuapp.com/users/?learn=django http://coderaising-ethan.herokuapp.com/users/?learn=Django

brianjyee commented 11 years ago

I found a fork of django-taggit here that allows a TAGGIT_FORCE_LOWERCASE = True setting. This library, however, is not the standard library that will be installed when you run pip install django-taggit. Instead, I forked the repo so I have my own copy of it, and I ran pip install git+https://github.com/brianjyee/django-taggit.git. This worked and my app is successfully forcing tags to be lowercase.

According to this Heroku documentation, it should be able to support anything that is installable by pip. But I'm not sure what to put in the requirements.txt file. If I do pip freeze, a different version of django-taggit is listed. I can't test on Heroku. Does anyone know how to make this work? Should I just submit a pull request and have Ethan test?

esoergel commented 11 years ago

Yeah, submit a pull request and I'll give it a try

natea commented 11 years ago

Is there some reason we're using django-taggit instead of Mezzanine's built-in keyword facility? http://mezzanine.jupo.org/docs/utilities.html#keywords

On Sun, Jun 23, 2013 at 7:02 PM, Ethan Soergel notifications@github.comwrote:

Yeah, submit a pull request and I'll give it a try

— Reply to this email directly or view it on GitHubhttps://github.com/esoergel/coderaising/issues/19#issuecomment-19883358 .

nate@appsembler.com +1 (617) 517-4953 http://twitter.com/natea | http://linkedin.com/in/natea

brianjyee commented 11 years ago

Nope, I just googled for the most popular django tagging library and it worked until we realized that it doesn't have built in lower case settings. I can try rebuilding it using the mezzanine feature but I might not have time to do that before Thursday.

esoergel commented 11 years ago

It would be nice to use the mezzanine default. I think taggit and mezzanine don't play well together; the account update feature mezzanine provides throws an error when it tries to display a string rendering of taggit tags. I wrote an account update form that does work, but I'd rather use the mezzanine one if possible.