Add alarm to timer - Githubissues

esong165 / cse110-w21-group25

2 stars 3 forks source link

Add alarm to timer #20

Closed esong165 closed 3 years ago

esong165 commented 3 years ago

As a musician using the timer to practice, I would like to: Hear an alarm when the countdown is over.

Additional Description: The timer should play a sound when the countdown event is over.

Tasks

[x] Implement sound to be played at the end of a countdown timer.

DuckDuckWhaleUCSD commented 3 years ago

@esong165 I'm not sure how we should have unit tests for playing alarm. I'm inclined to skip that requirement since there isn't functional code to test (we could test it, but it would require lots of refactoring (to separate data and view) and mocking that isn't necessary right now). Do you think it is worth doing a MVC model refactor to incorporate the tests, or is the current testing model "good enough" for now?

esong165 commented 3 years ago

You're right, sound testing would not be in the scope of unit tests. I'll edit the issue and mark it as completed.