search

esong165 / cse110-w21-group25

2 stars 3 forks source link

Tasklist styled tasklist, settings, stats #89

Closed bananahbatman closed 3 years ago

bananahbatman commented 3 years ago

Added select highlight functionality to tasklist. Added various button changes. Styled tasklist, settings, and stats.

DuckDuckWhaleUCSD commented 3 years ago

Good job on the styling though, looks much better!

esong165 commented 3 years ago

Changed all but one of the requested edits (the #select-settings p change, and also maybe check if the indentation of the shadow innerHTMLs is proper), somewhat of a fix to bugs 1 and 3 (style people, please look over my change to see if it still looks fine).

I couldn't really address the FireFox issues because on FireFox 86.0 for Windows 64 bit, the displays look fine (checkbox is pixelated but the position is fine, and design group should be working on that soon). May just need to bump up minimum screen width or something.

Still not too sure what the image problem entails (I might just be too tired right now) -- trashcan.png is used as the default image, and trashcan_black.png is the image displayed on hover.

DuckDuckWhaleUCSD commented 3 years ago

Need to resolve conflicts and push the new commits @esong165

DuckDuckWhaleUCSD commented 3 years ago

Merging in favor of velocity and not requiring everything to be polished in one go. PR is also getting out of hand and scope due to fixing too many things at once. Some of the issues are half existing already and are tracked. Planning on fixing the checkbox in a new PR right after merging this.