esotalk / esoTalk

Fat-free forum software.
GNU General Public License v2.0
1.47k stars 236 forks source link

difference in online member count when hidden #365

Open tvb opened 10 years ago

tvb commented 10 years ago

There is an difference in the online member count when there are hidden members online.

screen shot 2014-10-23 at 23 14 14

tvb commented 10 years ago
    // If we're ordering by last active, filter out members who have opted out of being displayed on the online list.
    if ($orderBy == "activity") {
        foreach ($members as $k => $member) {
            if (!empty($member["preferences"]["hideOnline"])) {
                unset($members[$k]);
            }
        }
    }
tobyzerner commented 10 years ago

What should the behaviour be? "Online members (2)"?

tvb commented 10 years ago

Yeah would be my suggestion. There are simply 2 members online of which one is unknown.

jgknight commented 9 years ago

@tvb did you already fix this? Or were you just proposing a fix? I'm fine with either way we count them, as long as we're consistent throughout.

tvb commented 9 years ago

@Thirtysixway negative, I have not been able to propose a fix yet.