This is probably a controversial pull request, but I decided to suggest it anyways. I am developing an esoTalk forum app for Nextcloud over here. (*)
Unfortunately, Nextcloud runs PHP with strict error reporting and I additionally add open_basedir restrictions on top. The first patch in this pull request fixes many warnings esoTalk emits with PHP strict reporting. The second patch fixes warnings due to open_basedir. These should have no particular effect on standard esoTalk installations, since I (hopefully) did not change any code semantics.
The only limitation I can see is that the array indexing for function returns only works with PHP 5.4 and above. So feel free to reject this pull request or cherry-pick from it. Or ask me questions for particular changes.
(*) I know that I will have to transition to Flarum in the near future, but I am maintaining this anyways, because it is in active use for a project I manage.
This is probably a controversial pull request, but I decided to suggest it anyways. I am developing an esoTalk forum app for Nextcloud over here. (*)
Unfortunately, Nextcloud runs PHP with strict error reporting and I additionally add
open_basedirrestrictions on top. The first patch in this pull request fixes many warnings esoTalk emits with PHP strict reporting. The second patch fixes warnings due toopen_basedir. These should have no particular effect on standard esoTalk installations, since I (hopefully) did not change any code semantics.The only limitation I can see is that the array indexing for function returns only works with PHP 5.4 and above. So feel free to reject this pull request or cherry-pick from it. Or ask me questions for particular changes.
(*) I know that I will have to transition to Flarum in the near future, but I am maintaining this anyways, because it is in active use for a project I manage.