RxUtils.unsubscribe vs CompositeSubscription

esoxjem / MovieGuide

Movie discovery app showcasing MVP, RxJava, Dagger 2 and Clean Architecture

MIT License

2.61k stars 857 forks source link

RxUtils.unsubscribe vs CompositeSubscription #17

Closed wotomas closed 7 years ago

wotomas commented 7 years ago

I am curious, is there a specific reason why you decided to use

RxUtils.unsubscribe(trailersSubscription, reviewSubscription);

over

CompositeSubscription unsubscribe()

:D just curious!

esoxjem commented 7 years ago

@wotomas I find creating + adding + unsubscribing from a CompositeSubscription every time a bit cumbersome, something that Uncle Bob calls "Temporal Coupling". Using a utility function seems more succinct.

wotomas commented 7 years ago

I see, it makes sense! thanks!