Moving to rxJava2 - Githubissues

esoxjem / MovieGuide

Movie discovery app showcasing MVP, RxJava, Dagger 2 and Clean Architecture

MIT License

2.61k stars 857 forks source link

Moving to rxJava2 #41

Closed MattiaPrimavera closed 7 years ago

MattiaPrimavera commented 7 years ago

Hi, here's a little summary of what it took,

update retrofit2 call factory for rx2
moving rx. to io.reactivex.
moving Subscription to Disposable
moving testSubscriber to testObserver
fixing RxAndroidSchedulersHook

Plus

0109961e4f0e833f5aac7d1b3b7c383f38061813: Updating gradle plugin version: 2.3.1 -> 2.3.3
a661d169329709ce6cb433dbdcb0e22bb034a897: rxJava2 gradle imports added + fixing META-INF duplicate file issue

Tests are all passing.

MattiaPrimavera commented 7 years ago

shouldBeAbleToShowTrailers and shouldBeAbleToShowReviews tests keeps failing sometimes only, it may be that those two are not run in a deterministic way, since the result is not always the same. Any idea why ?

esoxjem commented 7 years ago

@MattiaPrimavera The tests should pass as is, there's should't be any need to update them. Just change the TestRule to an RxJava2 rule instead. Something like this.

MattiaPrimavera commented 7 years ago

I followed this article and played a little with the @Rule, but I did not really get why it does seem working with the @Rule annotation on every PresenterImpl but on the MovieListing one