search

esoxjem / MovieGuide

Movie discovery app showcasing MVP, RxJava, Dagger 2 and Clean Architecture
MIT License
2.61k stars 857 forks source link

Add API as a preference #69

Closed Rudloff closed 6 years ago

Rudloff commented 6 years ago

Hello,

Instead of adding the API key before building the app, would it be possible to add an option to enter an API key in the app preferences. This would allow changing the key without rebuilding the app.

esoxjem commented 6 years ago

Hey @Rudloff, you need to build the code at least once anyway.

Rudloff commented 6 years ago

Yes, but not every body knows how to build an app.

I assumed you were not distributing APKs with your API key because the TMDB API is rate-limited. This would allow distributing key-less APK and let people enter the key manually.

rijogeorge7 commented 6 years ago

I think if we do so ,we can distribute this app and when user open the app for the first time we can ask the user to enter an api key to proceed

esoxjem commented 6 years ago

I need to have a bit more features in before I consider this and distribute on F-Droid. Thanks for the suggestions @Rudloff @rijogeorge7