esp-cpp / espp

C++ components for ESP
https://esp-cpp.github.io/espp/
MIT License
28 stars 9 forks source link

Issue building without Nimble enabled #238

Closed abrondijk closed 1 month ago

abrondijk commented 1 month ago

Answers checklist.

General issue report

I think you may have forgotten to check for BT_NIMBLE_ENABLED in gfps_service.cpp. The source file does not include <string> and it can also not find the espp namespace when Nimble is disabled.

Adding the same macros as in other files from that component resolves the issue:

#include "gfps_service.hpp"

#if CONFIG_BT_NIMBLE_ENABLED || defined(_DOXYGEN_)

const std::string espp::GfpsService::MODEL_ID_UUID = "fe2c1233-8366-4814-8eb0-01de32100bea";
const std::string espp::GfpsService::KB_PAIRING_UUID = "fe2c1234-8366-4814-8eb0-01de32100bea";
const std::string espp::GfpsService::PASSKEY_UUID = "fe2c1235-8366-4814-8eb0-01de32100bea";
const std::string espp::GfpsService::ACCOUNT_KEY_UUID = "fe2c1236-8366-4814-8eb0-01de32100bea";

#endif