esp-cpp / espp

C++ components for ESP
https://esp-cpp.github.io/espp/
MIT License
28 stars 9 forks source link

fix(nvs): fix hard-coded ns/key in bool overloads #242

Closed finger563 closed 1 month ago

finger563 commented 1 month ago

Description

Motivation and Context

The bool overloads for the nvs functions had a copy/paste hard-coded namespace and key value. This fixes that issue. It also adds additional overloads for accepting std::string_view and updates the error codes to be NVS specific.

How has this been tested?

Building and running nvs/example on a QtPy ESP32S3.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

CleanShot 2024-05-18 at 12 54 46 CleanShot 2024-05-18 at 12 54 54 CleanShot 2024-05-18 at 12 55 02

Types of changes

Checklist:

Software

github-actions[bot] commented 1 month ago

:white_check_mark:Static analysis result - no issues found! :white_check_mark: