esp-rs / embuild

Build support for embedded Rust: Cargo integration with other embedded build ecosystems & tools, like PlatformIO, CMake and kconfig.
Apache License 2.0
135 stars 38 forks source link

Use reponse file on windows and when using gcc #15

Closed N3xed closed 3 years ago

N3xed commented 3 years ago

This is to circumvent the command-line length limitation on windows.

Export shlex::join as join_unix_args Export shlex::quote as quote_unix_arg Change LinkArgsBuilder::build to return a Result<LinkArgs> Add cargo::out_dir

ivmarkov commented 3 years ago

Looks OK, I'll merge. BTW, these changes probably fall within the perhaps-not-necessary-to-peer-review category, as the API changes are minimal and the rest is Windows specific stuff we have to address anyway.

(Edit: I've submitted a separate issue for the problem below) Related: I am half there in figuring out the linkage problems with the native build and the C3 chip:

Unresolved questions/issues: