Closed N3xed closed 3 years ago
Looks OK, I'll merge. BTW, these changes probably fall within the perhaps-not-necessary-to-peer-review category, as the API changes are minimal and the rest is Windows specific stuff we have to address anyway.
(Edit: I've submitted a separate issue for the problem below) Related: I am half there in figuring out the linkage problems with the native build and the C3 chip:
-nodefaultlibs
option on the command line, which seems to be kind of like "the default behavior" (but it seems you can control this on a Rust target level, when you define the target)__trunctfdf2
); if I remove the -nodefaultlibs
, it works OKrustflags = ["-C", "default-linker-libraries"]
to the [target.riscv32imc-esp-espidf]
section in .cargo/config.toml
in the relevant binary crate (rust-esp32-std-hello
etcetera)riscv32imc-esp-espidf
as well as in all xtensa targets, if it is not allowed there). Reason why I believe this is a correct behavior: I don't see the -nodefaultlibs
argument amongst the "native" (cmake) args, which means the native ESP-IDF build is assuming it is NOT setUnresolved questions/issues:
-nodefaultlibs
option, or that particular intrinsic is simply not needed on Xtensa. Not sure
This is to circumvent the command-line length limitation on windows.
Export
shlex::join
asjoin_unix_args
Exportshlex::quote
asquote_unix_arg
ChangeLinkArgsBuilder::build
to return aResult<LinkArgs>
Addcargo::out_dir