search

esp-rs / embuild

Build support for embedded Rust: Cargo integration with other embedded build ecosystems & tools, like PlatformIO, CMake and kconfig.
Apache License 2.0
135 stars 38 forks source link

esp-idf installation support #21

Closed N3xed closed 2 years ago

N3xed commented 2 years ago

An initial implementation to allow installing the esp-idf source and tools using embuild itself. I wan't to make the installation a bit more configurable (i.e. install location, ...) before I consider it ready, though it should already work fine.

The first commit also contains some minor API improvements and fixes.

N3xed commented 2 years ago

I'm however still unsure why the "private" installation (in the crate folder) has to be in an .espressif folder, instead of in an .embuild/espressif folder as I once suggested. The latter would allow me to implement a similar private installation of PlatformIO in .embuild/platformio folder (the public being ~/.platformio - very similar in spirit to ~/.espressif). With the benefit being that both are hidden inside .embuild, and we can just put .embuild in .gitignore.

Done.

Okay, this is probably ready to merge now.

ivmarkov commented 2 years ago

I'm however still unsure why the "private" installation (in the crate folder) has to be in an .espressif folder, instead of in an .embuild/espressif folder as I once suggested. The latter would allow me to implement a similar private installation of PlatformIO in .embuild/platformio folder (the public being ~/.platformio - very similar in spirit to ~/.espressif). With the benefit being that both are hidden inside .embuild, and we can just put .embuild in .gitignore.

Done.

Okay, this is probably ready to merge now.

Yep. Go ahead and merge it whenever you feel appropriate.