Fix issue where writing permissions while the file is open fails

esp-rs / embuild

Build support for embedded Rust: Cargo integration with other embedded build ecosystems & tools, like PlatformIO, CMake and kconfig.

Apache License 2.0

139 stars 40 forks source link

Fix issue where writing permissions while the file is open fails #56

Closed glynnmccabe closed 2 years ago

glynnmccabe commented 2 years ago

Fix an issue where permissions cannot be written to files while they are still open under windows. Presents as "Error: Access is denied. (os error 5)"

Causes issues downstream in esp-idf-sys when compiling under windows. See https://stackoverflow.com/questions/72969132/access-denied-when-building-esp-idf-sys-for-rust-project-for-esp32-on-windows-10

N3xed commented 2 years ago

Thank you very much for this fix (I realize now that I also have this problem on Windows...). Seems like we didn't test https://github.com/esp-rs/embuild/pull/51 on Windows which introduced this issue.

I will release 0.29.3 ~~shortly~~, done.