search

esp-rs / embuild

Build support for embedded Rust: Cargo integration with other embedded build ecosystems & tools, like PlatformIO, CMake and kconfig.
Apache License 2.0
135 stars 38 forks source link

Keep -isystem flags #76

Closed olby closed 1 year ago

olby commented 1 year ago

Extend the ulp_fsm::Builder::escape function to keep includes starting with -isystem.

ivmarkov commented 1 year ago

Just to make sure: you have seen #68 and my comments there?

olby commented 1 year ago

Just to make sure: you have seen #68 and my comments there?

Oh, looks like I shortcut the fix in this commit https://github.com/esp-rs/embuild/commit/c0e52801875b244e1279a6680f22a6a10f41dfad mentioned in #68

Will try to update the PR to not strip instead as you mentioned in the comment on the other pr.

ivmarkov commented 1 year ago

Make clippy happy pls :)

olby commented 1 year ago

Pretty new to Rust, did my best to make clippy happy.