Process overrides in custom tools logic

esp-rs / embuild

Build support for embedded Rust: Cargo integration with other embedded build ecosystems & tools, like PlatformIO, CMake and kconfig.

Apache License 2.0

139 stars 40 forks source link

Process overrides in custom tools logic #88

Closed tomstokes closed 4 months ago

tomstokes commented 4 months ago

The custom tools parsing logic introduced in https://github.com/esp-rs/embuild/pull/85 does not process the overrides in tools.json. This omission breaks compilation on macOS and likely several other platforms.

This commit adds override parsing logic to properly handle overrides from tools.json

Vollbrecht commented 4 months ago

Thanks for the PR! LGTM

Could you tell me if you tested it on aarch64 or x86 Mac?

Regarding the ARCH arm matching, i couldn't find a rust target that doesn't use "arm" so thanks for that.