search

esp-rs / embuild

Build support for embedded Rust: Cargo integration with other embedded build ecosystems & tools, like PlatformIO, CMake and kconfig.
Apache License 2.0
135 stars 38 forks source link

Fix platform matching in tools parsing #89

Closed tomstokes closed 2 months ago

tomstokes commented 2 months ago

The custom tools parsing logic introduced in https://github.com/esp-rs/embuild/pull/85 has incorrect ARCH values. The list of possible ARCH values can be found in the Rust documentation: https://doc.rust-lang.org/std/env/consts/constant.ARCH.html

Unfortunately, the Rust standard library doesn't distinguish between armel and armhf for 32-bit ARM, so this defaults to armel for 32-bit ARM.

The previous code would not properly match any ARM platforms (armv7 and armv8 are not possible ARCH values) and was missing 32-bit Linux.

Vollbrecht commented 2 months ago

closed as #88 contains this changes. Thanks!