Initial release usable in other projects (e.g. esptool-js)

esp-rs / esp-flasher-stub

Rust implementation of flasher stub located in esptool

Apache License 2.0

18 stars 10 forks source link

Initial release usable in other projects (e.g. esptool-js) #17

Closed igrr closed 11 months ago

igrr commented 1 year ago

[x] Update to latest esp-hal
[x] Generate releases of stubs, provide json files as artifacts
[x] https://github.com/esp-rs/esp-flasher-stub/issues/12 — Spend at least a few hours looking for opportunities to size reduce the binary size
[x] https://github.com/esp-rs/esp-flasher-stub/issues/15 — Is a nice-to-have, if we are including the stubs for C3 and S3 into this initial release.

jessebraham commented 1 year ago

I can look into automating the releases next week some time most likely.

jessebraham commented 1 year ago

JSON stub generator and release workflow added in #18

dobairoland commented 1 year ago

FYI @DNedic

jessebraham commented 1 year ago

Regarding the third task item, @MabezDev and I both did some brief investigation and without changing the code itself I don't think there's much more shrinking we can do. We both don't think that getting the size much smaller is super critical, either.

So, marking this task as complete. We should probably close the corresponding issue as well?

I think once we fix the remaining USB Serial JTAG issue we're probably in pretty good shape here.

jessebraham commented 11 months ago

I believe all tasks have been completed here, so other than the release itself this issue should be closable?

igrr commented 11 months ago

@jessebraham Agree, we can close this and make a release.

SergioGasquez commented 9 months ago

Just created https://github.com/esp-rs/espflash/pull/518 to use the generated stubs in espflash