Closed DNedic closed 2 months ago
We made that change in https://github.com/esp-rs/esp-flasher-stub/pull/50 because it was causing some issues (https://github.com/esp-rs/esp-flasher-stub/issues/49), I think I wasn't able to reproduce the issue, but the changes with the delay solved it for the user.
Thanks for the insight @SergioGasquez . Are we sure that it is the delay that fixed issues for the user and not other changes in that PR?
@radimkarnis PTAL as well
Thanks for the insight @SergioGasquez . Are we sure that it is the delay that fixed issues for the user and not other changes in that PR?
Not really, as we couldn't reproduce it on our end, I'd say it would be worth to merge this change. It should work with the same delay as C flasher stub, and we know where to look if this fails in the future.
Thanks for taking a look @SergioGasquez @dobairoland!
Late to the party, but LGTM! Better to have these aligned with the C stub.
While evaluating the use of
esp-flasher-stub
as a drop-in replacement for stub support inesp-serial-flasher
, I encountered issues tracing back to different delay intervals before changing the UART baudrate.This changes the delay so that it is in line with the
esptool
stub in order ensure the drop-in nature ofesp-flasher-stub
.In the future, we might want to consider adding
io.flush()
in order to remove all or almost all delays of this nature.